From: Chris Lattner Date: Sun, 11 Jan 2009 20:41:36 +0000 (+0000) Subject: Duncan is nervous about undefinedness of % with negatives. I'm X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=31a69cb9aec483f8bf3162cc98282f7c12e0c7fc;p=oota-llvm.git Duncan is nervous about undefinedness of % with negatives. I'm not thrilled about 64-bit % in general, so rewrite to use * instead. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@62047 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index b6604a930d6..49215317e26 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -7710,7 +7710,7 @@ static bool FindElementAtOffset(const Type *Ty, int64_t Offset, int64_t FirstIdx = 0; if (int64_t TySize = TD->getABITypeSize(Ty)) { FirstIdx = Offset/TySize; - Offset %= TySize; + Offset -= FirstIdx*TySize; // Handle hosts where % returns negative instead of values [0..TySize). if (Offset < 0) {