From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 16 Feb 2012 20:44:33 +0000 (+0000)
Subject: net/ethernet: ks8851_mll: signedness bug in ks8851_probe()
X-Git-Tag: firefly_0821_release~3680^2~3474^2~29
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=32aa64f77e032511079fec5ec0465aeb6d6c3891;p=firefly-linux-kernel-4.4.55.git

net/ethernet: ks8851_mll: signedness bug in ks8851_probe()

netdev->irq is unsigned, so it's never less than zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Jan Weitzel <j.weitzel@phytec.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
index 231176fcd2ba..2784bc706f1e 100644
--- a/drivers/net/ethernet/micrel/ks8851_mll.c
+++ b/drivers/net/ethernet/micrel/ks8851_mll.c
@@ -1545,7 +1545,7 @@ static int __devinit ks8851_probe(struct platform_device *pdev)
 
 	netdev->irq = platform_get_irq(pdev, 0);
 
-	if (netdev->irq < 0) {
+	if ((int)netdev->irq < 0) {
 		err = netdev->irq;
 		goto err_get_irq;
 	}