From: Neil Horman <nhorman@redhat.com>
Date: Tue, 21 Jul 2015 13:55:44 +0000 (-0400)
Subject: staging: unisys: Remove some extraneous start/stop queue operations
X-Git-Tag: firefly_0821_release~176^2~1221^2~493
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=35a8dd310efbbcec37de2da6301f9bdaf83b2632;p=firefly-linux-kernel-4.4.55.git
staging: unisys: Remove some extraneous start/stop queue operations
If we put them in the enable and disable paths, we don't need them in
several other places
Signed-off-by: Neil Horman <nhorman@redhat.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index 12318365ec7f..338ca8c29915 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -709,6 +709,7 @@ visornic_enable_with_timeout(struct net_device *netdev, const int timeout)
return -EIO;
}
+ netif_start_queue(netdev);
return 0;
}
@@ -730,7 +731,6 @@ visornic_timeout_reset(struct work_struct *work)
devdata = container_of(work, struct visornic_devdata, timeout_reset);
netdev = devdata->netdev;
- netif_stop_queue(netdev);
response = visornic_disable_with_timeout(netdev,
VISORNIC_INFINITE_RSP_WAIT);
if (response)
@@ -740,7 +740,6 @@ visornic_timeout_reset(struct work_struct *work)
VISORNIC_INFINITE_RSP_WAIT);
if (response)
goto call_serverdown;
- netif_wake_queue(netdev);
return;
@@ -760,11 +759,6 @@ visornic_open(struct net_device *netdev)
{
visornic_enable_with_timeout(netdev, VISORNIC_INFINITE_RSP_WAIT);
- /* start the interface's transmit queue, allowing it to accept
- * packets for transmission
- */
- netif_start_queue(netdev);
-
return 0;
}
@@ -778,7 +772,6 @@ visornic_open(struct net_device *netdev)
static int
visornic_close(struct net_device *netdev)
{
- netif_stop_queue(netdev);
visornic_disable_with_timeout(netdev, VISORNIC_INFINITE_RSP_WAIT);
return 0;