From: H Hartley Sweeten Date: Thu, 3 May 2012 00:17:23 +0000 (-0700) Subject: video: smscufx.c: local functions should not be exposed globally X-Git-Tag: firefly_0821_release~3680^2~2481^2~38 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=35f3ec1c224b823811e66450b1323eaabc11e982;p=firefly-linux-kernel-4.4.55.git video: smscufx.c: local functions should not be exposed globally Functions not referenced outside of a source file should be marked static to prevent them from being exposed globally. Quiets the sparse warnings: warning: symbol 'ufx_handle_damage' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Cc: Steve Glendinning Signed-off-by: Florian Tobias Schandinat --- diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c index 99857857f6fa..af3ef27ad36c 100644 --- a/drivers/video/smscufx.c +++ b/drivers/video/smscufx.c @@ -846,7 +846,7 @@ static void ufx_raw_rect(struct ufx_data *dev, u16 *cmd, int x, int y, } } -int ufx_handle_damage(struct ufx_data *dev, int x, int y, +static int ufx_handle_damage(struct ufx_data *dev, int x, int y, int width, int height) { size_t packed_line_len = ALIGN((width * 2), 4);