From: Davide Italiano <davide@freebsd.org>
Date: Thu, 19 Nov 2015 21:50:08 +0000 (+0000)
Subject: Follow up to r253591. Turn into an assertion.
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=38e5db618a6629a7273ae04210db2635a68bc4a7;p=oota-llvm.git

Follow up to r253591. Turn into an assertion.

Reported by: David Blaikie.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@253605 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/lib/Transforms/Instrumentation/AddressSanitizer.cpp
index 9048384164e..8eb82e39b8a 100644
--- a/lib/Transforms/Instrumentation/AddressSanitizer.cpp
+++ b/lib/Transforms/Instrumentation/AddressSanitizer.cpp
@@ -1216,8 +1216,7 @@ bool AddressSanitizerModule::ShouldInstrumentGlobal(GlobalVariable *G) {
       bool TAAParsed;
       std::string ErrorCode = MCSectionMachO::ParseSectionSpecifier(
           Section, ParsedSegment, ParsedSection, TAA, TAAParsed, StubSize);
-      if (!ErrorCode.empty())
-        llvm_unreachable("Invalid section specifier.");
+      assert(ErrorCode.empty() && "Invalid section specifier.");
 
       // Ignore the globals from the __OBJC section. The ObjC runtime assumes
       // those conform to /usr/lib/objc/runtime.h, so we can't add redzones to