From: Tomi Valkeinen Date: Thu, 10 May 2012 08:15:14 +0000 (+0300) Subject: OMAPFB: fix parsing of vram parameter X-Git-Tag: firefly_0821_release~3680^2~2624^2~18 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=3a028bb99d1f1e5c444060a176cbd4bf93530df3;p=firefly-linux-kernel-4.4.55.git OMAPFB: fix parsing of vram parameter omapfb_parse_vram_param()'s check for end pointer returned from simple_strtoul() is wrong, causing the code to bug if the second or later vram parameters are non-parseable, for example "omapfb.vram=0:2M,:5M". However, even in that case the code will most likely bail out with -EINVAL in the following checks, so the bug is probably not a fatal one. Signed-off-by: Tomi Valkeinen Reported-by: Hein Tibosch --- diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index b00db4068d21..7f02e7f90d63 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1502,7 +1502,7 @@ static int omapfb_parse_vram_param(const char *param, int max_entries, fbnum = simple_strtoul(p, &p, 10); - if (p == param) + if (p == start) return -EINVAL; if (*p != ':')