From: Florin Malita <fmalita@gmail.com>
Date: Fri, 26 May 2006 01:44:23 +0000 (-0700)
Subject: [PATCH] affs: possible null pointer dereference in affs_rename()
X-Git-Tag: firefly_0821_release~35650
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=3ac8141366932a74fd8620afaebd66960c91196d;p=firefly-linux-kernel-4.4.55.git

[PATCH] affs: possible null pointer dereference in affs_rename()

If affs_bread() fails, the exit path calls mark_buffer_dirty_inode() with a
NULL argument.

Coverity CID: 312.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index d4c2d636c479..a42143ca0169 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -416,10 +416,9 @@ affs_rename(struct inode *old_dir, struct dentry *old_dentry,
 			return retval;
 	}
 
-	retval = -EIO;
 	bh = affs_bread(sb, old_dentry->d_inode->i_ino);
 	if (!bh)
-		goto done;
+		return -EIO;
 
 	/* Remove header from its parent directory. */
 	affs_lock_dir(old_dir);