From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 27 May 2015 08:25:12 +0000 (+0300)
Subject: ARM: BCM63xx: fix an error path in bcm63xx_pmb_power_on_cpu()
X-Git-Tag: firefly_0821_release~176^2~1557^2~11^2~4
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=3cc630564e1ee9cca211ec0f14ef34cab30f21ed;p=firefly-linux-kernel-4.4.55.git

ARM: BCM63xx: fix an error path in bcm63xx_pmb_power_on_cpu()

We need to unlock and unmap some resourses before returning.

Fixes: 3f2a43c98d72 ('ARM: BCM63xx: Add secondary CPU PMB initialization sequence')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---

diff --git a/arch/arm/mach-bcm/bcm63xx_pmb.c b/arch/arm/mach-bcm/bcm63xx_pmb.c
index c39752b85b92..de061ec5a479 100644
--- a/arch/arm/mach-bcm/bcm63xx_pmb.c
+++ b/arch/arm/mach-bcm/bcm63xx_pmb.c
@@ -150,7 +150,7 @@ int bcm63xx_pmb_power_on_cpu(struct device_node *dn)
 	 */
 	ret = bpcm_rd(base, addr, ARM_CONTROL, &ctrl);
 	if (ret)
-		return ret;
+		goto out;
 
 	if (ctrl & CPU_RESET_N(cpu)) {
 		pr_info("PMB: CPU%d is already powered on\n", cpu);