From: Jesper Juhl <jj@chaosbits.net>
Date: Mon, 9 Apr 2012 20:51:25 +0000 (+0200)
Subject: remoteproc: remove redundant NULL check before release_firmware()
X-Git-Tag: firefly_0821_release~3680^2~2815^2~12
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=3cc6e78777ae6f577b67e26c76577ef357ac9009;p=firefly-linux-kernel-4.4.55.git

remoteproc: remove redundant NULL check before release_firmware()

release_firmware deals gracefully with NULL pointers, so checking
first is redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index ee15c68fb519..3d2884b0a4fc 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1105,8 +1105,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context)
 		goto out;
 
 out:
-	if (fw)
-		release_firmware(fw);
+	release_firmware(fw);
 	/* allow rproc_unregister() contexts, if any, to proceed */
 	complete_all(&rproc->firmware_loading_complete);
 }