From: Vasiliy Kulikov Date: Sun, 17 Oct 2010 14:41:24 +0000 (+0400) Subject: pcmcia: synclink_cs: fix information leak to userland X-Git-Tag: firefly_0821_release~9833^2~79^2^2~348 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=3d27e0b2b0717f4061261be79c46bfb6b1b9c3fa;p=firefly-linux-kernel-4.4.55.git pcmcia: synclink_cs: fix information leak to userland commit 5b917a1420d3d1a9c8da49fb0090692dc9aaee86 upstream. Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory. Signed-off-by: Vasiliy Kulikov Signed-off-by: Dominik Brodowski Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index 9ecd6bef5d3b..45f9fad4f5dc 100644 --- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -4127,6 +4127,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */