From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Mon, 15 Nov 2010 19:17:52 +0000 (-0800)
Subject: USB: storage: sierra_ms: fix sysfs file attribute
X-Git-Tag: firefly_0821_release~10186^2~678
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=3e4233a4069bed17484bbe17c7a3ee8ce9763f23;p=firefly-linux-kernel-4.4.55.git

USB: storage: sierra_ms: fix sysfs file attribute

commit d9624e75f6ad94d8a0718c1fafa89186d271a78c upstream.

A non-writable sysfs file shouldn't have writable attributes.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kevin Lloyd <klloyd@sierrawireless.com>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
index 4395c4100ec2..38e3c3aa05a1 100644
--- a/drivers/usb/storage/sierra_ms.c
+++ b/drivers/usb/storage/sierra_ms.c
@@ -120,7 +120,7 @@ static ssize_t show_truinst(struct device *dev, struct device_attribute *attr,
 	}
 	return result;
 }
-static DEVICE_ATTR(truinst, S_IWUGO | S_IRUGO, show_truinst, NULL);
+static DEVICE_ATTR(truinst, S_IRUGO, show_truinst, NULL);
 
 int sierra_ms_init(struct us_data *us)
 {