From: Mark Brown Date: Mon, 28 Jul 2014 11:32:04 +0000 (+0100) Subject: regulator: lp872x: Don't set constraints within the regulator driver X-Git-Tag: firefly_0821_release~176^2~3481^2~4^5 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=404d4df260bc7b224ba51c704d24b7e452d8b68c;p=firefly-linux-kernel-4.4.55.git regulator: lp872x: Don't set constraints within the regulator driver Regulator drivers should not be specifying constraints since the valid configurations depend on how the device is used in a given system, there is no way to know if a configuration is safe for a given board. Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c index 2e022aabd951..021d64d856bb 100644 --- a/drivers/regulator/lp872x.c +++ b/drivers/regulator/lp872x.c @@ -845,7 +845,6 @@ static struct lp872x_platform_data struct device_node *np = dev->of_node; struct lp872x_platform_data *pdata; struct of_regulator_match *match; - struct regulator_init_data *d; int num_matches; int count; int i; @@ -892,14 +891,6 @@ static struct lp872x_platform_data pdata->regulator_data[i].id = (enum lp872x_regulator_id)match[i].driver_data; pdata->regulator_data[i].init_data = match[i].init_data; - - /* Operation mode configuration for buck/buck1/buck2 */ - if (strncmp(match[i].name, "buck", 4)) - continue; - - d = pdata->regulator_data[i].init_data; - d->constraints.valid_modes_mask |= LP872X_VALID_OPMODE; - d->constraints.valid_ops_mask |= REGULATOR_CHANGE_MODE; } out: return pdata;