From: Tony Prisk Date: Wed, 16 Jan 2013 19:05:41 +0000 (+1300) Subject: serial: vt8500: ioremap'd resource is never freed X-Git-Tag: firefly_0821_release~3680^2~1078^2~72 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4053036580f0423be14e79483a939a4aef48c592;p=firefly-linux-kernel-4.4.55.git serial: vt8500: ioremap'd resource is never freed Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EADDRNOTAVAIL rather than -ENOMEM. Signed-off-by: Tony Prisk Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c index e50deb771616..ff391db0a220 100644 --- a/drivers/tty/serial/vt8500_serial.c +++ b/drivers/tty/serial/vt8500_serial.c @@ -606,9 +606,9 @@ static int vt8500_serial_probe(struct platform_device *pdev) snprintf(vt8500_port->name, sizeof(vt8500_port->name), "VT8500 UART%d", pdev->id); - vt8500_port->uart.membase = ioremap(mmres->start, resource_size(mmres)); + vt8500_port->uart.membase = devm_request_and_ioremap(&pdev->dev, mmres); if (!vt8500_port->uart.membase) { - ret = -ENOMEM; + ret = -EADDRNOTAVAIL; goto err; }