From: Dan Carpenter <error27@gmail.com>
Date: Mon, 28 Dec 2009 16:59:46 +0000 (-0300)
Subject: V4L/DVB (13955): cx25821: fix double unlock in medusa_video_init()
X-Git-Tag: firefly_0821_release~9833^2~3334^2~1
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=423f5c0d016cd6b65c468d3dcdeeb708ee68074b;p=firefly-linux-kernel-4.4.55.git

V4L/DVB (13955): cx25821: fix double unlock in medusa_video_init()

medusa_set_videostandard() takes the lock but it always drops it before
returning.

This was found with a static checker and compile tested only.  :/

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/staging/cx25821/cx25821-medusa-video.c b/drivers/staging/cx25821/cx25821-medusa-video.c
index e4df8134f059..1eb079b3d429 100644
--- a/drivers/staging/cx25821/cx25821-medusa-video.c
+++ b/drivers/staging/cx25821/cx25821-medusa-video.c
@@ -860,10 +860,8 @@ int medusa_video_init(struct cx25821_dev *dev)
 
 	ret_val = medusa_set_videostandard(dev);
 
-	if (ret_val < 0) {
-		mutex_unlock(&dev->lock);
+	if (ret_val < 0)
 		return -EINVAL;
-	}
 
 	return 1;
 }