From: Guenter Roeck Date: Mon, 23 Apr 2012 17:41:03 +0000 (-0700) Subject: hwmon: (ntc_thermistor) Return error code from hwmon_device_register X-Git-Tag: firefly_0821_release~3680^2~2793^2~6 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=425d247680d050fe3ee7e53b9cf0240bf6b4b351;p=firefly-linux-kernel-4.4.55.git hwmon: (ntc_thermistor) Return error code from hwmon_device_register hwmon_device_register() never returns a NULL pointer in case of errors, but an error value. Use it. Signed-off-by: Guenter Roeck Reviewed-by: Robert Coulson --- diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c index 4be7faff321b..b31bf1d3172a 100644 --- a/drivers/hwmon/ntc_thermistor.c +++ b/drivers/hwmon/ntc_thermistor.c @@ -382,9 +382,9 @@ static int __devinit ntc_thermistor_probe(struct platform_device *pdev) } data->hwmon_dev = hwmon_device_register(data->dev); - if (IS_ERR_OR_NULL(data->hwmon_dev)) { + if (IS_ERR(data->hwmon_dev)) { dev_err(data->dev, "unable to register as hwmon device.\n"); - ret = -EINVAL; + ret = PTR_ERR(data->hwmon_dev); goto err_after_sysfs; }