From: Wei Yongjun Date: Thu, 16 Apr 2015 12:17:46 +0000 (+0800) Subject: ASoC: tfa9879: Fix return value check in tfa9879_i2c_probe() X-Git-Tag: firefly_0821_release~176^2~1642^2~39^2^4 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=427ced4b203dfea4f08b1298cd1f88e19039fca4;p=firefly-linux-kernel-4.4.55.git ASoC: tfa9879: Fix return value check in tfa9879_i2c_probe() In case of error, the function devm_kzalloc() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun Acked-by: Peter Rosin Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index 16f1b71edb55..aab0af681e8c 100644 --- a/sound/soc/codecs/tfa9879.c +++ b/sound/soc/codecs/tfa9879.c @@ -280,8 +280,8 @@ static int tfa9879_i2c_probe(struct i2c_client *i2c, int i; tfa9879 = devm_kzalloc(&i2c->dev, sizeof(*tfa9879), GFP_KERNEL); - if (IS_ERR(tfa9879)) - return PTR_ERR(tfa9879); + if (!tfa9879) + return -ENOMEM; i2c_set_clientdata(i2c, tfa9879);