From: bdemsky <bdemsky>
Date: Wed, 8 Mar 2006 00:44:38 +0000 (+0000)
Subject: Finish semantic checks
X-Git-Tag: preEdgeChange~962
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=42e2e69f1b85905e6fde178adcb51269f1d37438;p=IRC.git

Finish semantic checks
---

diff --git a/Robust/src/IR/ClassDescriptor.java b/Robust/src/IR/ClassDescriptor.java
index 173db73b..e256baff 100644
--- a/Robust/src/IR/ClassDescriptor.java
+++ b/Robust/src/IR/ClassDescriptor.java
@@ -48,12 +48,14 @@ public class ClassDescriptor extends Descriptor {
 	    st+="extends "+superclass.toString();
 	st+=" {\n";
 	indent=TreeNode.INDENT;
-	
+	boolean printcr=false;
+
 	for(Iterator it=getFields();it.hasNext();) {
 	    FieldDescriptor fd=(FieldDescriptor)it.next();
 	    st+=TreeNode.printSpace(indent)+fd.toString()+"\n";
+	    printcr=true;
 	}
-	if (fields.size()>0)
+	if (printcr)
 	    st+="\n";
 
 	for(Iterator it=getMethods();it.hasNext();) {
diff --git a/Robust/src/IR/MethodDescriptor.java b/Robust/src/IR/MethodDescriptor.java
index 28eb9724..32061222 100644
--- a/Robust/src/IR/MethodDescriptor.java
+++ b/Robust/src/IR/MethodDescriptor.java
@@ -14,10 +14,12 @@ public class MethodDescriptor extends Descriptor {
     protected Modifiers modifier;
     protected TypeDescriptor returntype;
     protected String identifier;
-    protected Vector param_name;
-    protected Vector param_type;
+    protected Vector params;
     protected SymbolTable paramtable;
-    
+    protected ClassDescriptor cd;
+    protected VarDescriptor thisvd;
+
+
     public MethodDescriptor(Modifiers m, TypeDescriptor rt, String identifier) {
 	super(identifier);
 	this.modifier=m;
@@ -25,44 +27,85 @@ public class MethodDescriptor extends Descriptor {
 	this.identifier=identifier;
         this.safename = "__" + name + "__";
 	this.uniqueid=count++;
-	param_name=new Vector();
-	param_type=new Vector();
+	params=new Vector();
 	paramtable=new SymbolTable();
+	thisvd=null;
+    }
+
+    public MethodDescriptor(Modifiers m, String identifier) {
+	super(identifier);
+	this.modifier=m;
+	this.returntype=null;
+	this.identifier=identifier;
+        this.safename = "__" + name + "__";
+	this.uniqueid=count++;
+	params=new Vector();
+	paramtable=new SymbolTable();
+	thisvd=null;
+    }
+
+    public void setThis(VarDescriptor vd) {
+	thisvd=vd;
+	paramtable.add(vd);
+    }
+
+    public boolean isStatic() {
+	return modifier.isStatic();
     }
+
+    public boolean isConstructor() {
+	return (returntype==null);
+    }
+
     public TypeDescriptor getReturnType() {
 	return returntype;
     }
 
+    public void setClassDesc(ClassDescriptor cd) {
+	this.cd=cd;
+    }
+
+    public ClassDescriptor getClassDesc() {
+	return cd;
+    }
+
     public SymbolTable getParameterTable() {
 	return paramtable;
     }
 
     public void addParameter(TypeDescriptor type, String paramname) {
-	param_name.add(paramname);
-	param_type.add(type);
+	if (paramname.equals("this"))
+	    throw new Error("Can't have parameter named this");
+	VarDescriptor vd=new VarDescriptor(type, paramname);
+
+	params.add(vd);
 	if (paramtable.getFromSameScope(paramname)!=null) {
 	    throw new Error("Parameter "+paramname+" already defined");
 	}
-	paramtable.add(paramname,type);
+	paramtable.add(vd);
     }
 
     public int numParameters() {
-	return param_name.size();
+	return params.size();
     }
 
     public String getParamName(int i) {
-	return (String) param_name.get(i);
+	return ((VarDescriptor)params.get(i)).getName();
     }
 
     public TypeDescriptor getParamType(int i) {
-	return (TypeDescriptor) param_type.get(i);
+	return ((VarDescriptor)params.get(i)).getType();
     }
 
     public String toString() {
-	String st=modifier.toString()+returntype.toString()+" "+identifier+"(";
-	for(int i=0;i<param_type.size();i++) {
-	    st+=param_type.get(i).toString()+" "+param_name.get(i).toString();
-	    if ((i+1)!=param_type.size())
+	String st="";
+	if (returntype!=null)
+	    st=modifier.toString()+returntype.toString()+" "+identifier+"(";
+	else
+	    st=modifier.toString()+" "+identifier+"(";
+	for(int i=0;i<params.size();i++) {
+	    st+=getParamName(i)+" "+getParamType(i);
+	    if ((i+1)!=params.size())
 		st+=", ";
 	}
 	st+=")";
diff --git a/Robust/src/IR/NameDescriptor.java b/Robust/src/IR/NameDescriptor.java
index 65b3b64e..344d57c8 100644
--- a/Robust/src/IR/NameDescriptor.java
+++ b/Robust/src/IR/NameDescriptor.java
@@ -15,6 +15,21 @@ public class NameDescriptor extends Descriptor {
 	nd=null;
     }
 
+    public String getIdentifier() {
+	return identifier;
+    }
+
+    public NameDescriptor getBase() {
+	return nd;
+    }
+
+    public String getRoot() {
+	if (nd==null)
+	    return identifier;
+	else 
+	    return nd.getRoot();
+    }
+
     public String toString() {
 	if (nd==null) 
 	    return identifier;
diff --git a/Robust/src/IR/SymbolTable.java b/Robust/src/IR/SymbolTable.java
index a7218ffd..2c8bd2c5 100644
--- a/Robust/src/IR/SymbolTable.java
+++ b/Robust/src/IR/SymbolTable.java
@@ -6,9 +6,11 @@ public class SymbolTable {
 
     private Hashtable table;
     private SymbolTable parent;
+    private HashSet valueset;
   
     public SymbolTable() {
 	table = new Hashtable();
+	valueset = new HashSet();
 	this.parent = null;
     }
 
@@ -22,23 +24,43 @@ public class SymbolTable {
     }
     
     public void add(String name, Descriptor d) {
-	table.put(name, d);
+	if (!table.containsKey(name))
+	    table.put(name, new HashSet());
+	HashSet hs=(HashSet)table.get(name);
+	hs.add(d);
+	valueset.add(d);
     }
 
-    public void dump() {
-	Enumeration e = getDescriptors();
-	while (e.hasMoreElements()) {
-	    Descriptor d = (Descriptor) e.nextElement();
-	    System.out.println(d.getSymbol());
-	}
-	if (parent != null) {
-	    System.out.println("parent:");
-	    parent.dump();
+    public Set getSet(String name) {
+	return getPSet(name);
+    }
+
+    private HashSet getPSet(String name) {
+	HashSet hs=null;
+	if (parent!=null)
+	    hs=parent.getPSet(name);
+	else
+	    hs=new HashSet();
+	if (table.containsKey(name)) {
+	    hs.addAll((HashSet)table.get(name));
 	}
+	return hs;
     }
-    
+
+    public Set getSetFromSameScope(String name) {
+	return getPSetFromSameScope(name);
+    }
+
+    private HashSet getPSetFromSameScope(String name) {
+	if (table.containsKey(name)) {
+	    HashSet hs=(HashSet)table.get(name);
+	    return hs;
+	} else
+	    return new HashSet();
+    }
+
     public Descriptor get(String name) {
-	Descriptor d = (Descriptor) table.get(name);
+	Descriptor d = getFromSameScope(name);
 	if (d == null && parent != null) {
 	    return parent.get(name);
 	} else {
@@ -47,7 +69,12 @@ public class SymbolTable {
     }
 
     public Descriptor getFromSameScope(String name) {
-	return (Descriptor)table.get(name);
+	if (table.containsKey(name)) {
+	    HashSet hs=(HashSet) table.get(name);
+	    return (Descriptor) hs.iterator().next();
+	} else
+	    return null;
+
     }
     
     public Enumeration getNames() {
@@ -58,51 +85,32 @@ public class SymbolTable {
 	return table.keySet().iterator();
     }
 
-    public Enumeration getDescriptors() {
-	return table.elements();
+    public Set getValueSet() {
+	return valueset;
     }
 
     public Iterator getDescriptorsIterator() {
-	return table.values().iterator();
+	return getValueSet().iterator();
     }
 
-    public Iterator descriptors() {
-        return table.values().iterator();
+    public Set getAllValueSet() {
+	HashSet hs=null;
+	if (parent!=null)
+	    hs=(HashSet) parent.getAllValueSet();
+	else
+	    hs=new HashSet();
+	hs.addAll(valueset);
+	return hs;
     }
 
-    public Vector getAllDescriptors() {
-	Vector d;
-	if (parent == null) {
-	    d = new Vector();
-	} else {
-	    d = parent.getAllDescriptors();
-	}
-
-	Enumeration e = getDescriptors();
-	while(e.hasMoreElements()) {
-	    d.addElement(e.nextElement());
-	}
-
-	return d;
+    public Iterator getAllDescriptorsIterator() {
+	return getAllValueSet().iterator();
     }
 
     public boolean contains(String name) {
         return (get(name) != null);
     }
 	    
-	
-    public int size() {
-	return table.size();
-    }
-
-    public int sizeAll() {
-	if (parent != null) {
-	    return parent.sizeAll() + table.size();
-	} else {
-	    return table.size();
-	}
-    }
-
     public SymbolTable getParent() {
 	return parent;
     }
@@ -111,32 +119,6 @@ public class SymbolTable {
 	this.parent = parent;
     }
 
-    /**
-     * Adds contents of st2.table to this.table and returns a
-     * Vector of shared names, unless there are no shared names,
-     * in which case returns null.
-     */
-    public Vector merge(SymbolTable st2) {
-        Vector v = new Vector();
-        Enumeration names = st2.table.keys();
-
-        while (names.hasMoreElements()) {
-            Object o = names.nextElement();
-
-            if (table.containsKey(o)) {
-                v.addElement(o);
-            } else {
-                table.put(o, st2.table.get(o));
-            }
-        }
-
-        if (v.size() == 0) {
-            return null;
-        } else {
-            return v;
-        }
-    }
-
     public String toString() {
         return "ST: " + table.toString();               
     }
diff --git a/Robust/src/IR/Tree/BuildIR.java b/Robust/src/IR/Tree/BuildIR.java
index 0995b447..472254b6 100644
--- a/Robust/src/IR/Tree/BuildIR.java
+++ b/Robust/src/IR/Tree/BuildIR.java
@@ -51,6 +51,7 @@ public class BuildIR {
 		if (isNode(decl,"member")) {
 		    parseClassMember(cn,decl);
 		} else if (isNode(decl,"constructor")) {
+		    parseConstructorDecl(cn,decl.getChild("constructor_declaration"));
 		} else if (isNode(decl,"block")) {
 		} else throw new Error();
 	    }
@@ -237,6 +238,23 @@ public class BuildIR {
 	state.addTreeCode(md,bn);
     }
 
+    private void parseConstructorDecl(ClassDescriptor cn, ParseNode pn) {
+	ParseNode mn=pn.getChild("modifiers");
+	Modifiers m=parseModifiersList(mn);
+	ParseNode cdecl=pn.getChild("constructor_declarator");
+	String name=cdecl.getChild("name").getChild("identifier").getTerminal();
+	MethodDescriptor md=new MethodDescriptor(m, name);
+	ParseNode paramnode=cdecl.getChild("parameters");
+	parseParameterList(md,paramnode);
+	ParseNode bodyn0=pn.getChild("body");
+	ParseNode bodyn=bodyn0.getChild("constructor_body");
+	cn.addMethod(md);
+	if (bodyn!=null) {
+	    BlockNode bn=parseBlock(bodyn);
+	    state.addTreeCode(md,bn);
+	}
+    }
+
     public BlockNode parseBlock(ParseNode pn) {
 	if (isEmpty(pn.getTerminal()))
 	    return new BlockNode();
diff --git a/Robust/src/IR/Tree/MethodInvokeNode.java b/Robust/src/IR/Tree/MethodInvokeNode.java
index 08ad56f9..fe757fe0 100644
--- a/Robust/src/IR/Tree/MethodInvokeNode.java
+++ b/Robust/src/IR/Tree/MethodInvokeNode.java
@@ -4,16 +4,18 @@ import IR.NameDescriptor;
 import IR.MethodDescriptor;
 
 public class MethodInvokeNode extends ExpressionNode {
-    NameDescriptor nd;
     Vector argumentlist;
     String methodid;
+    NameDescriptor basename;
     ExpressionNode en;
     MethodDescriptor md;
 
     public MethodInvokeNode(NameDescriptor name) {
-	nd=name;
+	methodid=name.getIdentifier();
+	if (name.getBase()!=null) {
+	    basename=name.getBase();
+	}
 	argumentlist=new Vector();
-	methodid=null;
 	en=null;
 	md=null;
     }
@@ -21,15 +23,27 @@ public class MethodInvokeNode extends ExpressionNode {
     public MethodInvokeNode(String methodid, ExpressionNode exp) {
 	this.methodid=methodid;
 	this.en=exp;
-	nd=null;
 	argumentlist=new Vector();
 	md=null;
+	this.basename=null;
+    }
+
+    public NameDescriptor getBaseName() {
+	return basename;
+    }
+
+    public String getMethodName() {
+	return methodid;
     }
 
     public ExpressionNode getExpression() {
 	return en;
     }
 
+    public void setExpression(ExpressionNode en) {
+	this.en=en;
+    }
+
     public void setMethod(MethodDescriptor md) {
 	this.md=md;
     }
@@ -52,11 +66,8 @@ public class MethodInvokeNode extends ExpressionNode {
 
     public String printNode(int indent) {
 	String st;
-	if (nd==null) {
-	    st=en.printNode(indent)+"."+methodid+"(";
-   	} else {
-	    st=nd.toString()+"(";
-	}
+	st=en.printNode(indent)+"."+methodid+"(";
+
 	for(int i=0;i<argumentlist.size();i++) {
 	    ExpressionNode en=(ExpressionNode)argumentlist.get(i);
 	    st+=en.printNode(indent);
diff --git a/Robust/src/IR/Tree/Modifiers.java b/Robust/src/IR/Tree/Modifiers.java
index 3bcee6b1..f3b3af74 100644
--- a/Robust/src/IR/Tree/Modifiers.java
+++ b/Robust/src/IR/Tree/Modifiers.java
@@ -23,6 +23,10 @@ public class Modifiers {
 	value|=mod;
     }
 
+    public boolean isStatic() {
+	return ((value&STATIC)!=0);
+    }
+
     public String toString() {
 	String st="";
 	if ((value&PUBLIC)!=0)
diff --git a/Robust/src/IR/Tree/NameNode.java b/Robust/src/IR/Tree/NameNode.java
index b46df067..ecd731b9 100644
--- a/Robust/src/IR/Tree/NameNode.java
+++ b/Robust/src/IR/Tree/NameNode.java
@@ -2,21 +2,32 @@ package IR.Tree;
 import IR.NameDescriptor;
 import IR.VarDescriptor;
 import IR.TypeDescriptor;
+import IR.FieldDescriptor;
 
 public class NameNode extends ExpressionNode {
     NameDescriptor name;
     VarDescriptor vd;
+    FieldDescriptor fd;
 
     public NameNode(NameDescriptor nd) {
 	this.name=nd;
+	this.vd=null;
+	this.fd=null;
     }
 
     public void setVar(VarDescriptor vd) {
 	this.vd=vd;
     }
 
+    public void setField(FieldDescriptor fd) {
+	this.fd=fd;
+    }
+
     public TypeDescriptor getType() {
-	return vd.getType();
+	if (vd!=null)
+	    return vd.getType();
+	else
+	    return fd.getType();
     }
 
     NameDescriptor getName() {
diff --git a/Robust/src/IR/Tree/OpNode.java b/Robust/src/IR/Tree/OpNode.java
index 3b80faba..cd4ddccd 100644
--- a/Robust/src/IR/Tree/OpNode.java
+++ b/Robust/src/IR/Tree/OpNode.java
@@ -1,10 +1,12 @@
 package IR.Tree;
 import IR.Operation;
+import IR.TypeDescriptor;
 
 public class OpNode extends ExpressionNode {
     ExpressionNode left;
     ExpressionNode right;
     Operation op;
+    TypeDescriptor td;
 
     public OpNode(ExpressionNode l, ExpressionNode r, Operation o) {
 	left=l;
@@ -36,6 +38,15 @@ public class OpNode extends ExpressionNode {
 	else
 	    return left.printNode(indent)+" "+op.toString()+" "+right.printNode(indent);
     }
+
+    public TypeDescriptor getType() {
+	return td;
+    }
+
+    public void setType(TypeDescriptor td) {
+	this.td=td;
+    }
+
     public int kind() {
 	return Kind.OpNode;
     }
diff --git a/Robust/src/IR/Tree/SemanticCheck.java b/Robust/src/IR/Tree/SemanticCheck.java
index 2374185a..cd5776e4 100644
--- a/Robust/src/IR/Tree/SemanticCheck.java
+++ b/Robust/src/IR/Tree/SemanticCheck.java
@@ -69,14 +69,21 @@ public class SemanticCheck {
 
     public void checkMethod(ClassDescriptor cd, MethodDescriptor md) {
 	/* Check return type */
-	if (!md.getReturnType().isVoid())
-	    checkTypeDescriptor(md.getReturnType());
+	if (!md.isConstructor())
+	    if (!md.getReturnType().isVoid())
+		checkTypeDescriptor(md.getReturnType());
+
 	for(int i=0;i<md.numParameters();i++) {
 	    TypeDescriptor param_type=md.getParamType(i);
 	    checkTypeDescriptor(param_type);
 	}
 	/* Link the naming environments */
 	md.getParameterTable().setParent(cd.getFieldTable());
+	md.setClassDesc(cd);
+	if (!md.isStatic()) {
+	    VarDescriptor thisvd=new VarDescriptor(new TypeDescriptor(cd),"this");
+	    md.setThis(thisvd);
+	}
     }
 
     public void checkMethodBody(ClassDescriptor cd, MethodDescriptor md) {
@@ -257,11 +264,15 @@ public class SemanticCheck {
     void checkNameNode(MethodDescriptor md, SymbolTable nametable, NameNode nn, TypeDescriptor td) {
 	NameDescriptor nd=nn.getName();
 	String varname=nd.toString();
-	VarDescriptor vd=(VarDescriptor)nametable.get(varname);
-	if (vd==null) {
-	    throw new Error("Variable "+varname+" undefined");
+	Descriptor d=(Descriptor)nametable.get(varname);
+	if (d==null) {
+	    throw new Error("Name "+varname+" undefined");
+	}
+	if (d instanceof VarDescriptor) {
+	    nn.setVar((VarDescriptor)d);
+	} else if (d instanceof FieldDescriptor) {
+	    nn.setField((FieldDescriptor)d);
 	}
-	nn.setVar(vd);
 	if (td!=null)
 	    if (!typeutil.isSuperorType(td,nn.getType()))
 		throw new Error("Field node returns "+nn.getType()+", but need "+td);
@@ -300,12 +311,144 @@ public class SemanticCheck {
 
 
     void checkCreateObjectNode(MethodDescriptor md, SymbolTable nametable, CreateObjectNode con, TypeDescriptor td) {
+	TypeDescriptor[] tdarray=new TypeDescriptor[con.numArgs()];
+	for(int i=0;i<con.numArgs();i++) {
+	    ExpressionNode en=con.getArg(i);
+	    checkExpressionNode(md,nametable,en,null);
+	    tdarray[i]=en.getType();
+	}
+
+	TypeDescriptor typetolookin=con.getType();
+	checkTypeDescriptor(typetolookin);
+	if (!typetolookin.isClass()) 
+	    throw new Error();
+
+	ClassDescriptor classtolookin=typetolookin.getClassDesc();
+	System.out.println("Looking for "+typetolookin.getSymbol());
+	System.out.println(classtolookin.getMethodTable());
+
+	Set methoddescriptorset=classtolookin.getMethodTable().getSet(typetolookin.getSymbol());
+	MethodDescriptor bestmd=null;
+	NextMethod:
+	for(Iterator methodit=methoddescriptorset.iterator();methodit.hasNext();) {
+	    MethodDescriptor currmd=(MethodDescriptor)methodit.next();
+	    /* Need correct number of parameters */
+	    System.out.println("Examining: "+currmd);
+	    if (con.numArgs()!=currmd.numParameters())
+		continue;
+	    for(int i=0;i<con.numArgs();i++) {
+		if (!typeutil.isSuperorType(currmd.getParamType(i),tdarray[i]))
+		    continue NextMethod;
+	    }
+	    /* Method okay so far */
+	    if (bestmd==null)
+		bestmd=currmd;
+	    else {
+		if (isMoreSpecific(currmd,bestmd)) {
+		    bestmd=currmd;
+		} else if (!isMoreSpecific(bestmd, currmd))
+		    throw new Error("No method is most specific");
+		
+		/* Is this more specific than bestmd */
+	    }
+	}
+	if (bestmd==null)
+	    throw new Error("No method found for "+con.printNode(0));
+	con.setConstructor(bestmd);
+
 	
     }
 
 
-    void checkMethodInvokeNode(MethodDescriptor md, SymbolTable nametable, MethodInvokeNode min, TypeDescriptor td) {
+    /** Check to see if md1 is more specific than md2...  Informally
+	if md2 could always be called given the arguments passed into
+	md1 */
+
+    boolean isMoreSpecific(MethodDescriptor md1, MethodDescriptor md2) {
+	/* Checks if md1 is more specific than md2 */
+	if (md1.numParameters()!=md2.numParameters())
+	    throw new Error();
+	for(int i=0;i<md1.numParameters();i++) {
+	    if (!typeutil.isSuperorType(md2.getParamType(i), md1.getParamType(i)))
+		return false;
+	}
+	if (!typeutil.isSuperorType(md2.getReturnType(), md1.getReturnType()))
+		return false;
+	return true;
+    }
 
+    ExpressionNode translateNameDescriptorintoExpression(NameDescriptor nd) {
+	String id=nd.getIdentifier();
+	NameDescriptor base=nd.getBase();
+	if (base==null) 
+	    return new NameNode(nd);
+	else 
+	    return new FieldAccessNode(translateNameDescriptorintoExpression(base),id);
+    }
+
+
+    void checkMethodInvokeNode(MethodDescriptor md, SymbolTable nametable, MethodInvokeNode min, TypeDescriptor td) {
+	/*Typecheck subexpressions
+	  and get types for expressions*/
+
+	TypeDescriptor[] tdarray=new TypeDescriptor[min.numArgs()];
+	for(int i=0;i<min.numArgs();i++) {
+	    ExpressionNode en=min.getArg(i);
+	    checkExpressionNode(md,nametable,en,null);
+	    tdarray[i]=en.getType();
+	}
+	TypeDescriptor typetolookin=null;
+	if (min.getExpression()!=null) {
+	    checkExpressionNode(md,nametable,min.getExpression(),null);
+	    typetolookin=min.getExpression().getType();
+	} else if (min.getBaseName()!=null) {
+	    String rootname=min.getBaseName().getRoot();
+	    if (nametable.get(rootname)!=null) {
+		//we have an expression
+		min.setExpression(translateNameDescriptorintoExpression(min.getBaseName()));
+		checkExpressionNode(md, nametable, min.getExpression(), null);
+		typetolookin=min.getExpression().getType();
+	    } else {
+		//we have a type
+		ClassDescriptor cd=typeutil.getClass(min.getBaseName().getSymbol());
+		if (cd==null)
+		    throw new Error(min.getBaseName()+" undefined");
+		typetolookin=new TypeDescriptor(cd);
+	    }
+	} else {
+	    typetolookin=new TypeDescriptor(md.getClassDesc());
+	}
+	if (!typetolookin.isClass()) 
+	    throw new Error();
+	ClassDescriptor classtolookin=typetolookin.getClassDesc();
+	System.out.println("Method name="+min.getMethodName());
+	Set methoddescriptorset=classtolookin.getMethodTable().getSet(min.getMethodName());
+	MethodDescriptor bestmd=null;
+	NextMethod:
+	for(Iterator methodit=methoddescriptorset.iterator();methodit.hasNext();) {
+	    MethodDescriptor currmd=(MethodDescriptor)methodit.next();
+	    /* Need correct number of parameters */
+	    if (min.numArgs()!=currmd.numParameters())
+		continue;
+	    for(int i=0;i<min.numArgs();i++) {
+		if (!typeutil.isSuperorType(currmd.getParamType(i),tdarray[i]))
+		    continue NextMethod;
+	    }
+	    /* Method okay so far */
+	    if (bestmd==null)
+		bestmd=currmd;
+	    else {
+		if (isMoreSpecific(currmd,bestmd)) {
+		    bestmd=currmd;
+		} else if (!isMoreSpecific(bestmd, currmd))
+		    throw new Error("No method is most specific");
+		
+		/* Is this more specific than bestmd */
+	    }
+	}
+	if (bestmd==null)
+	    throw new Error("No method found for :"+min.printNode(0));
+	min.setMethod(bestmd);
     }
 
 
@@ -336,8 +479,9 @@ public class SemanticCheck {
 		thistype=ltd;
 	}
 	on.setType(thistype);
-	if (!typeutil.isSuperorType(td, thistype))
-	    throw new Error("Type of rside not compatible with type of lside"+on.printNode(0));	
+	if (td!=null)
+	    if (!typeutil.isSuperorType(td, thistype))
+		throw new Error("Type of rside not compatible with type of lside"+on.printNode(0));	
     }
 
 
diff --git a/Robust/src/IR/TypeDescriptor.java b/Robust/src/IR/TypeDescriptor.java
index 27f57ebc..80bf5164 100644
--- a/Robust/src/IR/TypeDescriptor.java
+++ b/Robust/src/IR/TypeDescriptor.java
@@ -49,7 +49,6 @@ public class TypeDescriptor extends Descriptor {
 	return type==DOUBLE;
     }
 
-
     public void setClassDescriptor(ClassDescriptor cd) {
 	class_desc=cd;
     }
diff --git a/Robust/src/Parse/java14.cup b/Robust/src/Parse/java14.cup
index 761df786..60abe1e9 100644
--- a/Robust/src/Parse/java14.cup
+++ b/Robust/src/Parse/java14.cup
@@ -622,8 +622,8 @@ constructor_declaration ::=
 //throws_opt 
 			constructor_body:body	{:
 		ParseNode pn=new ParseNode("constructor_declaration");
-		pn.addChild("modifier").addChild(mo);
-		pn.addChild("declarator").addChild(cd);
+		pn.addChild("modifiers").addChild(mo);
+		pn.addChild(cd);
 		pn.addChild("body").addChild(body);
 		RESULT=pn;
 	:}
@@ -631,7 +631,7 @@ constructor_declaration ::=
 constructor_declarator ::=
 		simple_name:name LPAREN formal_parameter_list_opt:fplo RPAREN {: 
 		ParseNode pn=new ParseNode("constructor_declarator");
-		pn.addChild("name").addChild(name);
+		pn.addChild(name);
 		pn.addChild("parameters").addChild(fplo);
 		RESULT=pn;
 	:}
@@ -641,7 +641,7 @@ constructor_body ::=
 //		LBRACE explicit_constructor_invocation RBRACE |
 		LBRACE block_statements:block RBRACE {: 
 		ParseNode pn=new ParseNode("constructor_body");
-		pn.addChild("block").addChild(block);
+		pn.addChild(block);
 		RESULT=pn;
 	:}
 	|	LBRACE RBRACE {: RESULT=new ParseNode("empty"); :}