From: Justin Bogner Date: Wed, 7 May 2014 16:01:27 +0000 (+0000) Subject: llvm-cov: Explicitly namespace llvm::make_unique to keep MSVC happy X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=459a8aaee2e590e54fb94708c147a9248777c899;p=oota-llvm.git llvm-cov: Explicitly namespace llvm::make_unique to keep MSVC happy This is a followup to r208171, where a call to make_unique was disambiguated for MSVC. Disambiguate two more calls, and remove the comment about it since this is what we do everywhere. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208219 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/IR/GCOV.cpp b/lib/IR/GCOV.cpp index e8d26e0d9e1..f2099d6baf1 100644 --- a/lib/IR/GCOV.cpp +++ b/lib/IR/GCOV.cpp @@ -511,16 +511,14 @@ std::string FileInfo::getCoveragePath(StringRef Filename, std::unique_ptr FileInfo::openCoveragePath(StringRef CoveragePath) { if (Options.NoOutput) - return make_unique(); + return llvm::make_unique(); std::string ErrorInfo; - // FIXME: When using MSVS, we end up having both std::make_unique and - // llvm::make_unique which conflict. Explicitly use the llvm:: version. auto OS = llvm::make_unique(CoveragePath.str().c_str(), ErrorInfo, sys::fs::F_Text); if (!ErrorInfo.empty()) { errs() << ErrorInfo << "\n"; - return make_unique(); + return llvm::make_unique(); } return std::move(OS); }