From: Guenter Roeck Date: Wed, 11 Sep 2013 17:35:47 +0000 (-0700) Subject: hwmon: (nct6775) Check array index when accessing temp_offset X-Git-Tag: firefly_0821_release~176^2~5013^2~46 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=45a5b3a183b43e07b7d1eaf1ef7c00fc87511b1b;p=firefly-linux-kernel-4.4.55.git hwmon: (nct6775) Check array index when accessing temp_offset smatch complains about a potential out-of-bounds access to the temp_offset array. That doesn't happen in practice, but it doesn't hurt to add an explicit check either. This prevents potential problems in the future (for example if the number of 'fixed' temperature sensors is increased to add support for another chip). Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index de57e0d60d23..b82fad487777 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c @@ -1457,7 +1457,8 @@ static struct nct6775_data *nct6775_update_device(struct device *dev) = nct6775_read_temp(data, data->reg_temp[j][i]); } - if (!(data->have_temp_fixed & (1 << i))) + if (i >= NUM_TEMP_FIXED || + !(data->have_temp_fixed & (1 << i))) continue; data->temp_offset[i] = nct6775_read_value(data, data->REG_TEMP_OFFSET[i]);