From: Eric Millbrandt Date: Tue, 22 Dec 2009 15:13:24 +0000 (-0500) Subject: ASoC: Do not write to invalid registers on the wm9712. X-Git-Tag: firefly_0821_release~11625^2~466 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=474ae5e72b8acc3c79354f0b14e77fb9e09108ff;p=firefly-linux-kernel-4.4.55.git ASoC: Do not write to invalid registers on the wm9712. commit 48e3cbb3f67a27d9c2db075f3d0f700246c40caa upstream. This patch fixes a bug where "virtual" registers were being written to the ac97 bus. This was causing unrelated registers to become corrupted (headphone 0x04, touchscreen 0x78, etc). This patch duplicates protection that was included in the wm9713 driver. Signed-off-by: Eric Millbrandt Acked-by: Liam Girdwood Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c index 1fd4e88f50cf..e9123f54202d 100644 --- a/sound/soc/codecs/wm9712.c +++ b/sound/soc/codecs/wm9712.c @@ -464,7 +464,8 @@ static int ac97_write(struct snd_soc_codec *codec, unsigned int reg, { u16 *cache = codec->reg_cache; - soc_ac97_ops.write(codec->ac97, reg, val); + if (reg < 0x7c) + soc_ac97_ops.write(codec->ac97, reg, val); reg = reg >> 1; if (reg < (ARRAY_SIZE(wm9712_reg))) cache[reg] = val;