From: Fabio Estevam Date: Mon, 30 Dec 2013 20:03:24 +0000 (-0200) Subject: regulator: wm831x-dcdc: Remove unneeded 'err' label X-Git-Tag: firefly_0821_release~176^2~4568^2^9 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=477b2bacb1bc30c62e390dbb8fda08bdef274d82;p=firefly-linux-kernel-4.4.55.git regulator: wm831x-dcdc: Remove unneeded 'err' label There is no need to jump to the 'err' label. Returnn the error directly instead. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c index 6823e6f2b88a..04cf9c16ef23 100644 --- a/drivers/regulator/wm831x-dcdc.c +++ b/drivers/regulator/wm831x-dcdc.c @@ -762,8 +762,7 @@ static int wm831x_boostp_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_REG, 0); if (res == NULL) { dev_err(&pdev->dev, "No REG resource\n"); - ret = -EINVAL; - goto err; + return -EINVAL; } dcdc->base = res->start; @@ -788,7 +787,7 @@ static int wm831x_boostp_probe(struct platform_device *pdev) ret = PTR_ERR(dcdc->regulator); dev_err(wm831x->dev, "Failed to register DCDC%d: %d\n", id + 1, ret); - goto err; + return ret; } irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV")); @@ -799,15 +798,12 @@ static int wm831x_boostp_probe(struct platform_device *pdev) if (ret != 0) { dev_err(&pdev->dev, "Failed to request UV IRQ %d: %d\n", irq, ret); - goto err; + return ret; } platform_set_drvdata(pdev, dcdc); return 0; - -err: - return ret; } static struct platform_driver wm831x_boostp_driver = {