From: Markus Elfring Date: Fri, 21 Nov 2014 11:40:32 +0000 (+0100) Subject: tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put" X-Git-Tag: firefly_0821_release~176^2~2678^2~2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=48f5cde566201f987125ec783f40dc84b69ce300;p=firefly-linux-kernel-4.4.55.git tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put" The tty_kref_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/hvc/hvsi_lib.c b/drivers/tty/hvc/hvsi_lib.c index 7ae6c293e518..a270f04588d7 100644 --- a/drivers/tty/hvc/hvsi_lib.c +++ b/drivers/tty/hvc/hvsi_lib.c @@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp) hvsi_send_close(pv); } - if (pv->tty) - tty_kref_put(pv->tty); + tty_kref_put(pv->tty); pv->tty = NULL; }