From: Chris Metcalf Date: Thu, 1 Aug 2013 15:36:42 +0000 (-0400) Subject: tile: make "tile_net.custom" a proper bool module parameter X-Git-Tag: firefly_0821_release~176^2~5420^2~387 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4aa02644b9c4e2f43ba0c13fefa39e9fd3a71da3;p=firefly-linux-kernel-4.4.55.git tile: make "tile_net.custom" a proper bool module parameter Signed-off-by: Chris Metcalf Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/tile/tilegx.c b/drivers/net/ethernet/tile/tilegx.c index 6d94d58d4287..7302e84c36a9 100644 --- a/drivers/net/ethernet/tile/tilegx.c +++ b/drivers/net/ethernet/tile/tilegx.c @@ -256,11 +256,11 @@ static char *network_cpus_string; /* The actual cpus in "network_cpus". */ static struct cpumask network_cpus_map; -/* If "loopify=LINK" was specified, this is "LINK". */ +/* If "tile_net.loopify=LINK" was specified, this is "LINK". */ static char *loopify_link_name; -/* If "tile_net.custom" was specified, this is non-NULL. */ -static char *custom_str; +/* If "tile_net.custom" was specified, this is true. */ +static bool custom_flag; /* If "tile_net.jumbo=NUM" was specified, this is "NUM". */ static uint jumbo_num; @@ -323,7 +323,7 @@ MODULE_PARM_DESC(loopify, "name the device to use loop0/1 for ingress/egress"); /* The "tile_net.custom" argument causes us to ignore the "conventional" * classifier metadata, in particular, the "l2_offset". */ -module_param_named(custom, custom_str, charp, 0444); +module_param_named(custom, custom_flag, bool, 0444); MODULE_PARM_DESC(custom, "indicates a (heavily) customized classifier"); /* The "tile_net.jumbo" argument causes us to support "jumbo" packets, @@ -501,7 +501,7 @@ static bool tile_net_handle_packet(int instance, gxio_mpipe_idesc_t *idesc) } /* Get the "l2_offset", if allowed. */ - l2_offset = custom_str ? 0 : gxio_mpipe_idesc_get_l2_offset(idesc); + l2_offset = custom_flag ? 0 : gxio_mpipe_idesc_get_l2_offset(idesc); /* Get the VA (including NET_IP_ALIGN bytes of "headroom"). */ va = tile_io_addr_to_va((unsigned long)idesc->va);