From: H Hartley Sweeten Date: Tue, 4 Jun 2013 02:04:03 +0000 (-0700) Subject: staging: comedi: pcmda12: tidy up subdevice init X-Git-Tag: firefly_0821_release~176^2~5845^2~281 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4b2ebd8dea7f0cf20ce3cccc45a60dfb7853b3ea;p=firefly-linux-kernel-4.4.55.git staging: comedi: pcmda12: tidy up subdevice init For aesthetic reasons. add some whitespace to the subdevice init and reorder it a bit. Remove the 's->private = NULL', it was kzalloc'ed by the core and will already be NULL. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/pcmda12.c b/drivers/staging/comedi/drivers/pcmda12.c index dfd2bff46e1a..c725a9b0982e 100644 --- a/drivers/staging/comedi/drivers/pcmda12.c +++ b/drivers/staging/comedi/drivers/pcmda12.c @@ -167,14 +167,13 @@ static int pcmda12_attach(struct comedi_device *dev, return ret; s = &dev->subdevices[0]; - s->private = NULL; - s->maxdata = 0x0fff; - s->range_table = &pcmda12_ranges; - s->type = COMEDI_SUBD_AO; - s->subdev_flags = SDF_READABLE | SDF_WRITABLE; - s->n_chan = CHANS; - s->insn_write = &ao_winsn; - s->insn_read = &ao_rinsn; + s->type = COMEDI_SUBD_AO; + s->subdev_flags = SDF_READABLE | SDF_WRITABLE; + s->n_chan = CHANS; + s->maxdata = 0x0fff; + s->range_table = &pcmda12_ranges; + s->insn_write = &ao_winsn; + s->insn_read = &ao_rinsn; zero_chans(dev); /* clear out all the registers, basically */