From: Daeseok Youn Date: Tue, 11 Mar 2014 07:31:03 +0000 (-0700) Subject: staging: unisys: remove incorrect error handling after queue_delayed_work X-Git-Tag: firefly_0821_release~176^2~4193^2~184 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4b4b535e64cdf404463b8eceba86c4f9d4391287;p=firefly-linux-kernel-4.4.55.git staging: unisys: remove incorrect error handling after queue_delayed_work The queue_delayed_work() return false if the work is already on the queue, true otherwise. So return value cannot be less than zero. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c index 2a9e30cdebe0..0e404e89ae96 100644 --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c @@ -2054,11 +2054,8 @@ Away: } } - if (queue_delayed_work(Periodic_controlvm_workqueue, - &Periodic_controlvm_work, Poll_jiffies) < 0) { - LOGERR("queue_delayed_work failed!"); - POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC, POSTCODE_SEVERITY_ERR); - } + queue_delayed_work(Periodic_controlvm_workqueue, + &Periodic_controlvm_work, Poll_jiffies); } static void @@ -2192,11 +2189,8 @@ Away: Poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_SLOW; - if (queue_delayed_work(Periodic_controlvm_workqueue, - &Periodic_controlvm_work, Poll_jiffies) < 0) { - LOGERR("queue_delayed_work failed!"); - POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC, POSTCODE_SEVERITY_ERR); - } + queue_delayed_work(Periodic_controlvm_workqueue, + &Periodic_controlvm_work, Poll_jiffies); } static void