From: Chris Lattner <sabre@nondot.org>
Date: Wed, 13 Jan 2010 08:02:14 +0000 (+0000)
Subject: add a fixme, ELF MCSection isn't quite right and weak unnamed globals are broken
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4d5f06fbe55ef7dd1d7709407d7b963965c077cf;p=oota-llvm.git

add a fixme, ELF MCSection isn't quite right and weak unnamed globals are broken
on linux (even though they are pointless, they shouldn't ICE).


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93308 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Target/TargetLoweringObjectFile.cpp b/lib/Target/TargetLoweringObjectFile.cpp
index bd683db8932..3ef2b3f3abb 100644
--- a/lib/Target/TargetLoweringObjectFile.cpp
+++ b/lib/Target/TargetLoweringObjectFile.cpp
@@ -578,6 +578,10 @@ SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind,
     const char *Prefix = getSectionPrefixForUniqueGlobal(Kind);
     SmallString<128> Name;
     Name.append(Prefix, Prefix+strlen(Prefix));
+    // FIXME: This will fail for weak globals with no names, this also depends
+    // on the mangling behavior of makeNameProper to mangle the section name
+    // before construction.  Instead, this should use getNameWithPrefix on the
+    // global variable and the MCSection printing code should do the mangling.
     Mang->makeNameProper(Name, GV->getName());
 
     return getELFSection(Name.str(),