From: Michel Dänzer <michel.daenzer@amd.com>
Date: Thu, 22 Jan 2015 07:00:17 +0000 (+0900)
Subject: reservation: Remove shadowing local variable 'ret'
X-Git-Tag: firefly_0821_release~176^2~2208^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4eb2440ed60fb5793f7aa6da89b3d517cc59de43;p=firefly-linux-kernel-4.4.55.git

reservation: Remove shadowing local variable 'ret'

It was causing the return value of fence_is_signaled to be ignored, making
reservation objects signal too early.

Cc: stable@vger.kernel.org
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
---

diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
index 807ef1555255..39920d77f288 100644
--- a/drivers/dma-buf/reservation.c
+++ b/drivers/dma-buf/reservation.c
@@ -405,8 +405,6 @@ reservation_object_test_signaled_single(struct fence *passed_fence)
 	int ret = 1;
 
 	if (!test_bit(FENCE_FLAG_SIGNALED_BIT, &lfence->flags)) {
-		int ret;
-
 		fence = fence_get_rcu(lfence);
 		if (!fence)
 			return -1;