From: Gabor Greif <ggreif@gmail.com>
Date: Fri, 17 Oct 2008 08:31:36 +0000 (+0000)
Subject: Add comment on how tagged pointers are
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=4fbed982fb09cb67c0d19ae553a06eb9321b3913;p=oota-llvm.git

Add comment on how tagged pointers are
distinguished from normal (untagged) ones
as per review comment.

I am sufficiently unaquainted with doxygen to
defer the markup to someone with more experience.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@57676 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/llvm/Use.h b/include/llvm/Use.h
index f88d4357c77..b4d2c488243 100644
--- a/include/llvm/Use.h
+++ b/include/llvm/Use.h
@@ -29,13 +29,20 @@ class User;
 //                          Generic Tagging Functions
 //===----------------------------------------------------------------------===//
 
+// We adhere to the following convention: The type of a tagged pointer
+// to T is T volatile*. This means that functions that superpose a tag
+// on a pointer will be supplied a T* (or T const*) and will return a
+// tagged one: T volatile*. Untagging functions do it the other way
+// 'round. While this scheme does not prevent dereferencing of tagged
+// pointers, proper type annotations do catch most inappropriate uses.
+
 /// Tag - generic tag type for (at least 32 bit) pointers
 enum Tag { noTag, tagOne, tagTwo, tagThree };
 
 /// addTag - insert tag bits into an (untagged) pointer
 template <typename T, typename TAG>
 inline volatile T *addTag(const T *P, TAG Tag) {
-    return reinterpret_cast<T*>(ptrdiff_t(P) | Tag);
+  return reinterpret_cast<T*>(ptrdiff_t(P) | Tag);
 }
 
 /// stripTag - remove tag bits from a pointer,