From: Julia Lawall Date: Sun, 22 Apr 2012 11:37:09 +0000 (+0200) Subject: drivers/staging/comedi/comedi_fops.c: add missing vfree X-Git-Tag: firefly_0821_release~7541^2~1153 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=512a8016c25d2045630b8933e7882169f7a98751;p=firefly-linux-kernel-4.4.55.git drivers/staging/comedi/comedi_fops.c: add missing vfree commit abae41e6438b798e046d721b6ccdd55b4a398170 upstream. aux_free is freed on all other exits from the function. By removing the return, we can benefit from the vfree already at the end of the function. Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 63e50f761828..ea8d109bb35e 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -280,7 +280,7 @@ static int do_devconfig_ioctl(struct comedi_device *dev, if (ret == 0) { if (!try_module_get(dev->driver->module)) { comedi_device_detach(dev); - return -ENOSYS; + ret = -ENOSYS; } }