From: Nick Lewycky <nicholas@mxc.ca>
Date: Wed, 6 Jun 2007 11:26:20 +0000 (+0000)
Subject: Optimize this test. Firstly, only Instructions may use other Instructions.
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=51e844b60168d019a293daddf19bd291c706dc3f;p=oota-llvm.git

Optimize this test. Firstly, only Instructions may use other Instructions.
Secondly, checking whether removal succeeded tells you whether it was in
the map to begin with.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@37469 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/ScalarEvolution.cpp b/lib/Analysis/ScalarEvolution.cpp
index b1c3a177273..bf67fd3fffc 100644
--- a/lib/Analysis/ScalarEvolution.cpp
+++ b/lib/Analysis/ScalarEvolution.cpp
@@ -1210,8 +1210,8 @@ void ScalarEvolutionsImpl::deleteInstructionFromRecords(Instruction *I) {
 
     for (Instruction::use_iterator UI = II->use_begin(), UE = II->use_end();
          UI != UE; ++UI) {
-      Instruction *Inst = dyn_cast<Instruction>(*UI);
-      if (Inst && hasSCEV(Inst) && Scalars.erase(Inst)) {
+      Instruction *Inst = cast<Instruction>(*UI);
+      if (Scalars.erase(Inst)) {
         if (PHINode *PN = dyn_cast<PHINode>(II))
           ConstantEvolutionLoopExitValue.erase(PN);
         Worklist.push_back(Inst);