From: Johan Hovold <jhovold@gmail.com>
Date: Thu, 25 Oct 2012 11:35:10 +0000 (+0200)
Subject: USB: mos7840: fix port-device leak in error path
X-Git-Tag: firefly_0821_release~7541^2~390
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=52fb227a7bddeb94b1e3a630755b232ddfc8a741;p=firefly-linux-kernel-4.4.55.git

USB: mos7840: fix port-device leak in error path

commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream.

The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index d79760c20f51..955b3fd4c031 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2595,7 +2595,6 @@ error:
 		kfree(mos7840_port->ctrl_buf);
 		usb_free_urb(mos7840_port->control_urb);
 		kfree(mos7840_port);
-		serial->port[i] = NULL;
 	}
 	return status;
 }