From: Chandler Carruth Date: Mon, 23 Aug 2010 08:25:07 +0000 (+0000) Subject: Fix some GCC warnings by providing a virtual destructor in the base of a class X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=54f616304240fcbc41ca9b9b2af38eeb1171e8a8;p=oota-llvm.git Fix some GCC warnings by providing a virtual destructor in the base of a class hierarchy with virtual methods and using llvm_unreachable to properly indicate unreachable states which would otherwise leave variables uninitialized. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@111803 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp b/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp index c9ad3ca5bf6..5f555934bae 100644 --- a/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp +++ b/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp @@ -1327,7 +1327,7 @@ SDValue SelectionDAGLegalize::LegalizeOp(SDValue Op) { break; case ISD::SEXTLOAD: ExtendOp = ISD::SIGN_EXTEND; break; case ISD::ZEXTLOAD: ExtendOp = ISD::ZERO_EXTEND; break; - default: assert(0 && "Unexpected extend load type!"); + default: llvm_unreachable("Unexpected extend load type!"); } Result = DAG.getNode(ExtendOp, dl, Node->getValueType(0), Load); Tmp1 = LegalizeOp(Result); // Relegalize new nodes. diff --git a/utils/TableGen/ClangAttrEmitter.cpp b/utils/TableGen/ClangAttrEmitter.cpp index ee606e0e50f..74ff6684265 100644 --- a/utils/TableGen/ClangAttrEmitter.cpp +++ b/utils/TableGen/ClangAttrEmitter.cpp @@ -71,6 +71,7 @@ namespace { upperName[0] = std::toupper(upperName[0]); } } + virtual ~Argument() {} StringRef getLowerName() const { return lowerName; } StringRef getUpperName() const { return upperName; }