From: Dirk Behme Date: Tue, 9 Dec 2014 09:11:24 +0000 (+0900) Subject: serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx() X-Git-Tag: firefly_0821_release~176^2~2319^2~96 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=55c3cb1358e57280c54e3578afc76ce8190dd087;p=firefly-linux-kernel-4.4.55.git serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx() Use imx_start_tx() just to enable the TX interrupt. It's the job of the TX interrupt ISR to fill the transmit buffer, then. If the transmit buffer is empty, the TX interrupt should be executed as soon as the start_tx() enables the interrupt, so there is no reason for the extra imx_transmit_buffer() call, here. Remove it. Signed-off-by: Dirk Behme Signed-off-by: Andy Lowe Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index c851247a27cb..146663c100fd 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -621,9 +621,6 @@ static void imx_start_tx(struct uart_port *port) imx_dma_tx(sport); return; } - - if (readl(sport->port.membase + uts_reg(sport)) & UTS_TXEMPTY) - imx_transmit_buffer(sport); } static irqreturn_t imx_rtsint(int irq, void *dev_id)