From: Chris Redpath <chris.redpath@arm.com>
Date: Fri, 29 Jun 2012 15:07:46 +0000 (+0100)
Subject: ARM HDLCD: Review comments from Liviu - extraneous memcpy
X-Git-Tag: firefly_0821_release~3680^2~236^2^2~11^2~7
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5705f5f9c6d47d59af73145b5febd1b1d5a56775;p=firefly-linux-kernel-4.4.55.git

ARM HDLCD: Review comments from Liviu - extraneous memcpy

Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Reviewed-By: Liviu Dudau <liviu.dudau@arm.com>
---

diff --git a/drivers/video/arm-hdlcd.c b/drivers/video/arm-hdlcd.c
index 8d5409db6b17..f16bb882e0c5 100644
--- a/drivers/video/arm-hdlcd.c
+++ b/drivers/video/arm-hdlcd.c
@@ -262,10 +262,10 @@ static int hdlcd_set_par(struct fb_info *info)
 	if (!memcmp(&info->var, &cached_var_screeninfo,
 				sizeof(struct fb_var_screeninfo))) {
 		if(old_yoffset != info->var.yoffset) {
-			/* we only changed yoffset */
+			/* we only changed yoffset, and we already
+			 * already recorded it a couple lines up
+			 */
 			hdlcd_pan_display(&info->var, info);
-			memcpy(&cached_var_screeninfo, &info->var,
-				sizeof(struct fb_var_screeninfo));
 		}
 		/* or no change */
 		return 0;