From: Jakub Staszak <kubastaszak@gmail.com>
Date: Thu, 1 Nov 2012 01:10:43 +0000 (+0000)
Subject: Don't insert and erase load instruction. Simply create (new) and delete it.
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5801ff93e3b81ee18fdd57f59d0e776ac3b27384;p=oota-llvm.git

Don't insert and erase load instruction. Simply create (new) and delete it.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@167196 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Scalar/SROA.cpp b/lib/Transforms/Scalar/SROA.cpp
index 1d0ba1c2c16..428aa8a472d 100644
--- a/lib/Transforms/Scalar/SROA.cpp
+++ b/lib/Transforms/Scalar/SROA.cpp
@@ -2521,12 +2521,12 @@ private:
       // the computed value, and then replace the placeholder with LI, leaving
       // LI only used for this computation.
       Value *Placeholder
-        = IRB.CreateLoad(UndefValue::get(LI.getType()->getPointerTo()));
+        = new LoadInst(UndefValue::get(LI.getType()->getPointerTo()));
       V = insertInteger(TD, IRB, Placeholder, V, BeginOffset,
                         getName(".insert"));
       LI.replaceAllUsesWith(V);
       Placeholder->replaceAllUsesWith(&LI);
-      cast<Instruction>(Placeholder)->eraseFromParent();
+      delete Placeholder;
       if (Pass.DeadSplitInsts.insert(&LI))
         Pass.DeadInsts.push_back(&LI);
       DEBUG(dbgs() << "          to: " << *V << "\n");