From: Tim Gardner <tim.gardner@canonical.com>
Date: Tue, 23 Feb 2010 13:59:12 +0000 (+0100)
Subject: netfilter: xt_recent: fix false match
X-Git-Tag: firefly_0821_release~10186^2~2074
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=58368fc8325ee2a9af4c29e232e319d78903f64b;p=firefly-linux-kernel-4.4.55.git

netfilter: xt_recent: fix false match

commit 8ccb92ad41cb311e52ad1b1fe77992c7f47a3b63 upstream.

A rule with a zero hit_count will always match.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c
index d940a6367c7a..1a3b6508060e 100644
--- a/net/netfilter/xt_recent.c
+++ b/net/netfilter/xt_recent.c
@@ -260,7 +260,7 @@ recent_mt(const struct sk_buff *skb, const struct xt_match_param *par)
 		for (i = 0; i < e->nstamps; i++) {
 			if (info->seconds && time_after(time, e->stamps[i]))
 				continue;
-			if (++hits >= info->hit_count) {
+			if (info->hit_count && ++hits >= info->hit_count) {
 				ret = !ret;
 				break;
 			}