From: Hans-Jürgen Koch <hjk@linutronix.de>
Date: Wed, 12 Sep 2007 19:20:43 +0000 (-0300)
Subject: V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init()
X-Git-Tag: firefly_0821_release~26079^2~80
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=588005e1008f2cea61b7a1ae2a86c531e99b8c9c;p=firefly-linux-kernel-4.4.55.git

V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init()

There's a serious bug in saa6588.c, it uses a non-initialized spin_lock.
Funny thing is that it works fine with bttv, but completly freezes the
machine if e.g. saa7134 is loaded.

Thanks to Derek Philip for reporting this bug on the rdsd-devel list.

This patch adds the missing spin_lock_init().

Signed-off-by: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/saa6588.c b/drivers/media/video/saa6588.c
index 92eabf88a09b..72e344a12c79 100644
--- a/drivers/media/video/saa6588.c
+++ b/drivers/media/video/saa6588.c
@@ -406,6 +406,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
 		kfree(s);
 		return -ENOMEM;
 	}
+	spin_lock_init(&s->lock);
 	s->client = client_template;
 	s->block_count = 0;
 	s->wr_index = 0;