From: Dan Gohman <gohman@apple.com>
Date: Thu, 2 Oct 2008 14:56:12 +0000 (+0000)
Subject: Work around an interaction between fast-isel and regalloc=local. The
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5bbee4b40a90f2825e229ed0f1d2b7b1ee7cd361;p=oota-llvm.git

Work around an interaction between fast-isel and regalloc=local. The
local register allocator's physreg liveness doesn't recognize subregs,
so it doesn't know that defs of %ecx that are immediately followed by
uses of %cl aren't dead. This comes up due to the way fast-isel emits
shift instructions.

This is a temporary workaround. Arguably, local regalloc should
handle subreg references correctly. On the other hand, perhaps
fast-isel should use INSERT_SUBREG instead of just assigning to the
most convenient super-register of %cl when lowering shifts.

This fixes MultiSource/Benchmarks/MallocBench/espresso,
MultiSource/Applications/hexxagon, and others, under -fast.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@56947 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Target/X86/X86FastISel.cpp b/lib/Target/X86/X86FastISel.cpp
index 59500ad8b1b..3d5759001f0 100644
--- a/lib/Target/X86/X86FastISel.cpp
+++ b/lib/Target/X86/X86FastISel.cpp
@@ -741,7 +741,11 @@ bool X86FastISel::X86SelectShift(Instruction *I) {
   if (Op1Reg == 0) return false;
   TII.copyRegToReg(*MBB, MBB->end(), CReg, Op1Reg, RC, RC);
   unsigned ResultReg = createResultReg(RC);
-  BuildMI(MBB, TII.get(OpReg), ResultReg).addReg(Op0Reg);
+  BuildMI(MBB, TII.get(OpReg), ResultReg).addReg(Op0Reg)
+    // FIXME: The "Local" register allocator's physreg liveness doesn't
+    // recognize subregs. Adding the superreg of CL that's actually defined
+    // prevents it from being re-allocated for this instruction.
+    .addReg(CReg, false, true);
   UpdateValueMap(I, ResultReg);
   return true;
 }