From: Sebastian Andrzej Siewior Date: Mon, 10 Sep 2012 17:06:44 +0000 (+0200) Subject: usb: gadget serial: don't shift bcd version left by 16 X-Git-Tag: firefly_0821_release~3680^2~1975^2~141^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5c4d46eb89fe99011a02048533857345d9e8b506;p=firefly-linux-kernel-4.4.55.git usb: gadget serial: don't shift bcd version left by 16 Fengguang Wu reported: |drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from |constant value (24000000 becomes 0) I obviously let the version number shift away. Since the version is a 16bit number it can be applied as it. Cc: fengguang.wu@intel.com Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c index 942067327d88..44752f531e85 100644 --- a/drivers/usb/gadget/serial.c +++ b/drivers/usb/gadget/serial.c @@ -86,7 +86,7 @@ static struct usb_device_descriptor device_desc = { /* .bMaxPacketSize0 = f(hardware) */ .idVendor = cpu_to_le16(GS_VENDOR_ID), /* .idProduct = f(use_acm) */ - .bcdDevice = cpu_to_le16(GS_VERSION_NUM << 16), + .bcdDevice = cpu_to_le16(GS_VERSION_NUM), /* .iManufacturer = DYNAMIC */ /* .iProduct = DYNAMIC */ .bNumConfigurations = 1,