From: Vivien Didelot Date: Tue, 30 Jul 2013 21:14:34 +0000 (-0400) Subject: hwmon: (max6697) fix MAX6581 ideality X-Git-Tag: firefly_0821_release~176^2~5603^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5c52add19733eb36d8619713312f5604efef3502;p=firefly-linux-kernel-4.4.55.git hwmon: (max6697) fix MAX6581 ideality Without this patch, the values for ideality (register 0x4b) and ideality selection mask (register 0x4c) are inverted. Signed-off-by: Vivien Didelot Cc: stable@vger.kernel.org # 3.9+ Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c index 328fb0353c17..a41b5f3fc506 100644 --- a/drivers/hwmon/max6697.c +++ b/drivers/hwmon/max6697.c @@ -605,12 +605,12 @@ static int max6697_init_chip(struct i2c_client *client) if (ret < 0) return ret; ret = i2c_smbus_write_byte_data(client, MAX6581_REG_IDEALITY, - pdata->ideality_mask >> 1); + pdata->ideality_value); if (ret < 0) return ret; ret = i2c_smbus_write_byte_data(client, MAX6581_REG_IDEALITY_SELECT, - pdata->ideality_value); + pdata->ideality_mask >> 1); if (ret < 0) return ret; }