From: Eric Christopher <echristo@gmail.com>
Date: Tue, 28 Apr 2015 18:09:05 +0000 (+0000)
Subject: Add a fixme to resetTargetOptions to explain why it needs to go
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5d8875707471e1869ccdfd985e6a97617b28c1f9;p=oota-llvm.git

Add a fixme to resetTargetOptions to explain why it needs to go
away.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236009 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Target/TargetMachine.cpp b/lib/Target/TargetMachine.cpp
index 5807cf7ca32..69900b012c4 100644
--- a/lib/Target/TargetMachine.cpp
+++ b/lib/Target/TargetMachine.cpp
@@ -54,6 +54,11 @@ TargetMachine::~TargetMachine() {
 }
 
 /// \brief Reset the target options based on the function's attributes.
+// FIXME: This function needs to go away for a number of reasons:
+// a) global state on the TargetMachine is terrible in general,
+// b) there's no default state here to keep,
+// c) these target options should be passed only on the function
+//    and not on the TargetMachine (via TargetOptions) at all.
 void TargetMachine::resetTargetOptions(const Function &F) const {
 #define RESET_OPTION(X, Y)                                                     \
   do {                                                                         \