From: Uwe Kleine-König Date: Mon, 12 Jan 2009 22:25:05 +0000 (+0100) Subject: move wm8400-regulator's probe function to .devinit.text X-Git-Tag: firefly_0821_release~15783^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=5dbdf7354821e00e4419ac3520d05d126857d56e;p=firefly-linux-kernel-4.4.55.git move wm8400-regulator's probe function to .devinit.text A pointer to wm8400_regulator_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Liam Girdwood --- diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm8400-regulator.c index 48b372e038a8..56e23d44ba59 100644 --- a/drivers/regulator/wm8400-regulator.c +++ b/drivers/regulator/wm8400-regulator.c @@ -289,7 +289,7 @@ static struct regulator_desc regulators[] = { }, }; -static int __init wm8400_regulator_probe(struct platform_device *pdev) +static int __devinit wm8400_regulator_probe(struct platform_device *pdev) { struct regulator_dev *rdev;