From: NeilBrown <neilb@suse.de>
Date: Tue, 16 Jul 2013 06:44:29 +0000 (+1000)
Subject: md: don't call md_allow_write in get_bitmap_file.
X-Git-Tag: firefly_0821_release~176^2~5359^2~13
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=60559da4d8c3259ea41a14ca4cfcd83022bff6bd;p=firefly-linux-kernel-4.4.55.git

md: don't call md_allow_write in get_bitmap_file.

There is no really need as GFP_NOIO is very likely sufficient,
and failure is not catastrophic.

Calling md_allow_write here will convert a read-auto array to
read/write which could be confusing when you are just performing
a read operation.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9f13e13506ef..bba87324c9b2 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5628,10 +5628,7 @@ static int get_bitmap_file(struct mddev * mddev, void __user * arg)
 	char *ptr, *buf = NULL;
 	int err = -ENOMEM;
 
-	if (md_allow_write(mddev))
-		file = kmalloc(sizeof(*file), GFP_NOIO);
-	else
-		file = kmalloc(sizeof(*file), GFP_KERNEL);
+	file = kmalloc(sizeof(*file), GFP_NOIO);
 
 	if (!file)
 		goto out;