From: Michael Ellerman Date: Tue, 2 Dec 2008 04:59:07 +0000 (-0800) Subject: IB/ipath: Fix pointer-to-pointer thinko in ipath_fs.c X-Git-Tag: firefly_0821_release~16483^2^3~7 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=64f22fa17c1a531e682ebc882566856ea5718495;p=firefly-linux-kernel-4.4.55.git IB/ipath: Fix pointer-to-pointer thinko in ipath_fs.c The return from lookup_one_len() is assigned to *dentry, so that's what we should be checking with IS_ERR(). Signed-off-by: Michael Ellerman Signed-off-by: Roland Dreier --- diff --git a/drivers/infiniband/hw/ipath/ipath_fs.c b/drivers/infiniband/hw/ipath/ipath_fs.c index 8bb5170b4e41..53912c327bfe 100644 --- a/drivers/infiniband/hw/ipath/ipath_fs.c +++ b/drivers/infiniband/hw/ipath/ipath_fs.c @@ -86,7 +86,7 @@ static int create_file(const char *name, mode_t mode, *dentry = NULL; mutex_lock(&parent->d_inode->i_mutex); *dentry = lookup_one_len(name, parent, strlen(name)); - if (!IS_ERR(dentry)) + if (!IS_ERR(*dentry)) error = ipathfs_mknod(parent->d_inode, *dentry, mode, fops, data); else