From: Shijin Kong <shikong@fb.com>
Date: Tue, 10 Nov 2015 23:06:52 +0000 (-0800)
Subject: change log error back to check when pipe read fail in notification queue
X-Git-Tag: deprecate-dynamic-initializer~266
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=658a60b37dd3af1676d7212bdef4cb2077191c56;p=folly.git

change log error back to check when pipe read fail in notification queue

Summary: Revert D2632752

Reviewed By: afrind

Differential Revision: D2638974

fb-gh-sync-id: 43d8135421510db7840a99f3c197119a0fd26c09
---

diff --git a/folly/io/async/NotificationQueue.h b/folly/io/async/NotificationQueue.h
index be53e495..9eee132b 100644
--- a/folly/io/async/NotificationQueue.h
+++ b/folly/io/async/NotificationQueue.h
@@ -511,9 +511,7 @@ class NotificationQueue {
     if (rc < 0) {
       // EAGAIN should pretty much be the only error we can ever get.
       // This means someone else already processed the only available message.
-      if (rc != EAGAIN) {
-        LOG(ERROR) << "non-EAGAIN error returned on pipe read: " << errno;
-      }
+      CHECK_EQ(errno, EAGAIN);
       return false;
     }
     assert(value == 1);