From: Douglas Anderson Date: Fri, 1 Apr 2016 20:48:41 +0000 (-0700) Subject: ARM64: dts: gru: fix up the pwm regulator node X-Git-Tag: firefly_0821_release~2869 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=66fd42ba64fbe1664c55b6cc88fc7a3eaa5b22a1;p=firefly-linux-kernel-4.4.55.git ARM64: dts: gru: fix up the pwm regulator node This attempts to model commit 063e65397a89 ("ARM64: dts: rk3399-tb: fix up the pwm regulator node"). Note that instead of putting a duty cycle of 25000 ns (40 kHz) I've set a duty cycle of 1667 ns (600 kHz) because I think that's what the TRM says. Change-Id: Ifc209eddb20122feec96c5e86f7a14da7d74eb3f Signed-off-by: Douglas Anderson Signed-off-by: Caesar Wang --- diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index 06c9496297f4..d53e77b5774b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi @@ -173,13 +173,16 @@ regulator-name = "ppvar_bigcpu"; status = "okay"; - pwms = <&pwm1 0 1000>; // TODO: schematics say "FSW 600KHz". Change these??? + // TODO: schematics say 600kHz so period of 1667 ns + // Rockchip has 25000 (40kHz) for these though. + pwms = <&pwm1 0 1667 0>; // TODO: where's the mapping of duty cycle to voltage??? // TODO: we probably need in-flight PWM regulator series? /* EC turns on w/ ap_core_en; always on for AP */ regulator-always-on; + regulator-boot-on; regulator-min-microvolt = <800000>; regulator-max-microvolt = <1500000>; @@ -192,10 +195,13 @@ regulator-name = "ppvar_litcpu"; status = "okay"; - pwms = <&pwm2 0 1000>; + // TODO: schematics say 600kHz so period of 1667 ns + // Rockchip has 25000 (40kHz) for these though. + pwms = <&pwm2 0 1667 0>; /* EC turns on w/ ap_core_en; always on for AP */ regulator-always-on; + regulator-boot-on; regulator-min-microvolt = <800000>; regulator-max-microvolt = <1500000>; @@ -208,10 +214,13 @@ regulator-name = "ppvar_gpu"; status = "okay"; - pwms = <&pwm0 0 1000>; + // TODO: schematics say 600kHz so period of 1667 ns + // Rockchip has 25000 (40kHz) for these though. + pwms = <&pwm0 0 1667 0>; /* EC turns on w/ ap_core_en; always on for AP */ regulator-always-on; + regulator-boot-on; regulator-min-microvolt = <800000>; regulator-max-microvolt = <1500000>; @@ -224,10 +233,13 @@ regulator-name = "ppvar_centerlogic"; status = "okay"; - pwms = <&pwm3 0 1000>; + // TODO: schematics say 600kHz so period of 1667 ns + // Rockchip has 25000 (40kHz) for these though. + pwms = <&pwm3 0 1667 0>; /* EC turns on w/ ppvar_centerlogic_en; always on for AP */ regulator-always-on; + regulator-boot-on; regulator-min-microvolt = <800000>; regulator-max-microvolt = <1500000>;