From: Sergey Kudakov Date: Fri, 21 Jan 2011 01:08:12 +0000 (-0600) Subject: misc: max9635: unregister upon probe failure X-Git-Tag: firefly_0821_release~9834^2~138 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=671ee8d974ced3c87c7772f91ec76a381ac25b3e;p=firefly-linux-kernel-4.4.55.git misc: max9635: unregister upon probe failure currently it only unregisters input device but not misc as a result in case if probe() fails it may cause a panic in ubsequently called ioctl where it would try to access unitialized/freed data Signed-off-by: Sergey Kudakov --- diff --git a/drivers/misc/max9635.c b/drivers/misc/max9635.c index 93f806229103..bcafebedd51d 100644 --- a/drivers/misc/max9635.c +++ b/drivers/misc/max9635.c @@ -548,6 +548,7 @@ err_req_irq_failed: err_reg_init_failed: input_unregister_device(als_data->idev); error_input_register_failed: + misc_deregister(&max9635_misc_device); error_misc_register_failed: input_free_device(als_data->idev); error_input_allocate_failed: