From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 12 Nov 2008 18:21:01 +0000 (-0800)
Subject: tracing/fastboot: fix perlcritic warning
X-Git-Tag: firefly_0821_release~13991^2~466^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=68f96c0c889b55bf62eee98e859cb686f8850188;p=firefly-linux-kernel-4.4.55.git

tracing/fastboot: fix perlcritic warning

Impact: cleanup

Fix the following warning from the perl syntax checking tool perlcritic.
This tool is a lint like tool that checks for perl best practices.

Loop iterator is not lexical at line 113, column 1.
See page 108 of PBP.  (Severity: 5)

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---

diff --git a/scripts/bootgraph.pl b/scripts/bootgraph.pl
index d2c61efc216f..a8635a10fef2 100644
--- a/scripts/bootgraph.pl
+++ b/scripts/bootgraph.pl
@@ -109,8 +109,8 @@ my $stylecounter = 0;
 my %rows;
 my $rowscount = 1;
 my @initcalls = sort { $start{$a} <=> $start{$b} } keys(%start);
-my $key;
-foreach $key (@initcalls) {
+
+foreach my $key (@initcalls) {
 	my $duration = $end{$key} - $start{$key};
 
 	if ($duration >= $threshold) {