From: Chris Lattner <sabre@nondot.org>
Date: Mon, 8 Apr 2002 22:05:54 +0000 (+0000)
Subject: Value cannot be directly instantiated.  I think that this code was TRYING to
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=69a34cddaf00ebd4ffdcbda15db0333134298703;p=oota-llvm.git

Value cannot be directly instantiated.  I think that this code was TRYING to
make a PHI node, although it was badly broken.  This keeps tests passing, so
we'll go with it.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@2184 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/InstrSelection/InstrSelection.cpp b/lib/CodeGen/InstrSelection/InstrSelection.cpp
index 1eb507a695b..583df38360a 100644
--- a/lib/CodeGen/InstrSelection/InstrSelection.cpp
+++ b/lib/CodeGen/InstrSelection/InstrSelection.cpp
@@ -202,11 +202,9 @@ InsertCode4AllPhisInMeth(Function *F, TargetMachine &target)
     //
     for( ; IIt != InstList.end(); ++IIt ) {
 
-      if( (*IIt)->getOpcode() == Instruction::PHINode ) {
-
-	PHINode *PN = (PHINode *) (*IIt);
-
-	Value *PhiCpRes = new Value(PN->getType(),PN->getValueType(),"PhiCp:");
+      if (PHINode *PN = dyn_cast<PHINode>(*IIt)) {
+        // FIXME: This is probably wrong...
+	Value *PhiCpRes = new PHINode(PN->getType(), "PhiCp:");
         
 	// for each incoming value of the phi, insert phi elimination
 	//
diff --git a/lib/Target/SparcV9/InstrSelection/InstrSelection.cpp b/lib/Target/SparcV9/InstrSelection/InstrSelection.cpp
index 1eb507a695b..583df38360a 100644
--- a/lib/Target/SparcV9/InstrSelection/InstrSelection.cpp
+++ b/lib/Target/SparcV9/InstrSelection/InstrSelection.cpp
@@ -202,11 +202,9 @@ InsertCode4AllPhisInMeth(Function *F, TargetMachine &target)
     //
     for( ; IIt != InstList.end(); ++IIt ) {
 
-      if( (*IIt)->getOpcode() == Instruction::PHINode ) {
-
-	PHINode *PN = (PHINode *) (*IIt);
-
-	Value *PhiCpRes = new Value(PN->getType(),PN->getValueType(),"PhiCp:");
+      if (PHINode *PN = dyn_cast<PHINode>(*IIt)) {
+        // FIXME: This is probably wrong...
+	Value *PhiCpRes = new PHINode(PN->getType(), "PhiCp:");
         
 	// for each incoming value of the phi, insert phi elimination
 	//