From: Duncan P. N. Exon Smith <dexonsmith@apple.com>
Date: Tue, 31 Mar 2015 02:37:13 +0000 (+0000)
Subject: Verifier: Don't return early from verifyTypeRefs()
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=6b9d1f9cee026ac605a87ae04e75e1add4012ac4;p=oota-llvm.git

Verifier: Don't return early from verifyTypeRefs()

We'll no longer crash in the `verifyTypeRefs()` (used to be called
`verifyDebugInfo()`), so there's no reason to return early here.  Remove
the `EverBroken` member since this was the only use!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@233665 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp
index 4adc56c6139..15fbea33d89 100644
--- a/lib/IR/Verifier.cpp
+++ b/lib/IR/Verifier.cpp
@@ -87,10 +87,9 @@ struct VerifierSupport {
 
   /// \brief Track the brokenness of the module while recursively visiting.
   bool Broken;
-  bool EverBroken;
 
   explicit VerifierSupport(raw_ostream &OS)
-      : OS(OS), M(nullptr), Broken(false), EverBroken(false) {}
+      : OS(OS), M(nullptr), Broken(false) {}
 
 private:
   void Write(const Value *V) {
@@ -145,7 +144,7 @@ public:
   /// something is not correct.
   void CheckFailed(const Twine &Message) {
     OS << Message << '\n';
-    EverBroken = Broken = true;
+    Broken = true;
   }
 
   /// \brief A check failed (with values to print).
@@ -3387,11 +3386,6 @@ void Verifier::visitUnresolvedTypeRef(const MDString *S, const MDNode *N) {
 }
 
 void Verifier::verifyTypeRefs() {
-  // Run the debug info verifier only if the regular verifier succeeds, since
-  // sometimes checks that have already failed will cause crashes here.
-  if (EverBroken || !VerifyDebugInfo)
-    return;
-
   auto *CUs = M->getNamedMetadata("llvm.dbg.cu");
   if (!CUs)
     return;